Skip to content

Allow Domain to specify what kind of nameservers it wants to use #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 16, 2018

Conversation

parkr
Copy link
Contributor

@parkr parkr commented May 15, 2018

Options include 'default', 'authoritative', or an array of nameserver IP's.

Added GitHubPages::HealthCheck::RedundantCheck.new(domain) which provides #valid?, #https_eligible? and #check. The last method, #check, returns the Domain instance which was "most valid".

Options include 'default', 'authoritative', or an array of nameserver IP's.
@parkr parkr requested review from benbalter and seveas May 15, 2018 17:12
@parkr
Copy link
Contributor Author

parkr commented May 16, 2018

Updated the OP. Gonna give this a try as v1.10.0.

@parkr parkr merged commit faa4ccd into master May 16, 2018
@parkr parkr deleted the customizable-nameservers branch May 16, 2018 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant