Skip to content

[Schema Inaccuracy] githubCloudOnly flag set incorrectly? #553

Open
@gr2m

Description

@gr2m

The following routes set x-github.githubCloudOnly to false, but I think it should be true?

PUT /orgs/{org}/actions/runner-groups/{runner_group_id}/runners/{runner_id}
POST /orgs/{org}/actions/runner-groups
DELETE /orgs/{org}/actions/runner-groups/{runner_group_id}
GET /orgs/{org}/actions/runner-groups/{runner_group_id}
GET /orgs/{org}/actions/runner-groups/{runner_group_id}/repositories
GET /orgs/{org}/actions/runner-groups
GET /orgs/{org}/actions/runner-groups/{runner_group_id}/runners
DELETE /orgs/{org}/actions/runner-groups/{runner_group_id}/repositories/{repository_id}
DELETE /orgs/{org}/actions/runner-groups/{runner_group_id}/runners/{runner_id}
PUT /orgs/{org}/actions/runner-groups/{runner_group_id}/repositories
PUT /orgs/{org}/actions/runner-groups/{runner_group_id}/runners
PATCH /orgs/{org}/actions/runner-groups/{runner_group_id}
PUT /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/organizations/{org_id}
PUT /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/runners/{runner_id}
POST /enterprises/{enterprise}/actions/runners/registration-token
POST /enterprises/{enterprise}/actions/runners/remove-token
POST /enterprises/{enterprise}/actions/runner-groups
DELETE /enterprises/{enterprise}/actions/runners/{runner_id}
DELETE /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}
GET /enterprises/{enterprise}/actions/runners/{runner_id}
GET /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}
GET /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/organizations
GET /enterprises/{enterprise}/actions/runners/downloads
GET /enterprises/{enterprise}/actions/runner-groups
GET /enterprises/{enterprise}/actions/runners
GET /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/runners
DELETE /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/organizations/{org_id}
DELETE /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/runners/{runner_id}
PUT /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/organizations
PUT /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}/runners
PATCH /enterprises/{enterprise}/actions/runner-groups/{runner_group_id}

Ages ago I added a workaround for Octokit to set the flag correctly:
https://github.com/gr2m/github-openapi-graphql-query/blob/405891d8cd001f2c126174e6f1bf5f9847213a54/lib/workarounds.js

Unfortunately I didn't write down why the flag was set to false, I think there was a more complicated reason? I also think you had a plan to publish a dedicated OpenAPI spec for GitHub Enterprise Cloud, is that still the plan?

/cc @Eddman octokit/plugin-rest-endpoint-methods.js#448

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions