Bump to axum 0.8 #151
Bump to axum 0.8 #151
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Good idea. We don't have a better way. Looking at the axum 0.8 release notes, it appears this is a pretty big change, so I suggest doing a breaking version-bump here as well (to twirp-rs 0.8 or whatever). The changes might not affect Blackbird - for example, I don't think we get any parameters from parsing request paths - but all three of the breaking changes described in the release notes affect things I've at least heard of, and it says there are other "less visible" breaking changes as well, so I'm not super optimistic. |
|
I made a blackbird PR that pulls in the @jorendorff Do we need to do some live tests in non-serving production clusters as well, before feeling good about finalizing the various PRs involved? |
|
@CleanCut Please branch-deploy to a non-serving cluster. The probers will tell us if anything's seriously wrong. |
|
Branch deployed, ran all night, no problems! 👍🏻 |
|
This PR was included in v0.8.0, released today. |
I updated
axumto0.8incrates/twirp/Cargo.tomland then rancargo test(which passed!) and committed the resulting updatedCargo.lockfile.@jorendorff How can I make sure this doesn't break things that use it? Will opening up a PR on
blackbirdthat points to this branch fortwirp-rs*be sufficient?Resolves #150
Once this is tested and merged, I anticipate publishing a new version of
twirp-rsandtwirp-build-rsto crates.io.