Skip to content

Remove unused settings and disable updating to prereleases of the CodeQL CLI by default #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Remove unused settings and disable updating to prereleases of the CodeQL CLI by default #15

merged 1 commit into from
Apr 16, 2020

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Apr 16, 2020

Remove ql.distribution.owner and ql.distribution.repository settings from the workspace since they are unused, and remove the ql.distribution.includePrereleases setting to disable including prereleases by default.

@henrymercer henrymercer requested a review from jcreedcmu April 16, 2020 17:37
@jcreedcmu
Copy link
Contributor

Do we want to references remove these from src/{distribution,config}.ts as well? I can't recall of the top of my head if vscode breaks or merely returns undefined if you try to ask for configuration items that aren't in package.json.

@henrymercer henrymercer changed the title Remove unused settings Remove unused settings and disable updating to prereleases of the CodeQL CLI by default Apr 16, 2020
@henrymercer
Copy link
Contributor Author

I've just checked and you're right that includePrerelease is still referenced in src/{distribution,config}.ts. The owner and repository settings haven't been referenced since github/vscode-codeql#174. The behaviour of VS Code is to return undefined when you look up a configuration item that isn't in package.json, so having an includePrelease setting that isn't in the package.json doesn't break anything.

I've updated the title of this PR and the commit message accordingly.

@jcreedcmu jcreedcmu merged commit 280269c into github:master Apr 16, 2020
Copy link
Contributor

@jcreedcmu jcreedcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in that case

@henrymercer henrymercer deleted the remove-unused-settings branch April 17, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants