Merge pull request #3972 from github/koesie10/fix-legacy-history-item-labels

koesie10 · web-flow · commit 139226f5c697 · 2025-03-27T11:16:04.000+01:00
Fix legacy label regex
diff --git a/extensions/ql-vscode/src/query-history/history-item-label-provider.ts b/extensions/ql-vscode/src/query-history/history-item-label-provider.ts
@@ -64,6 +64,7 @@ export class HistoryItemLabelProvider {
     const rawLabel =
       item.userSpecifiedLabel ?? (this.config.format || "${queryName}");
 
+    legacyLabelRegex.lastIndex = 0; // Reset the regex index to start searching from the start of the string if the strings are the same
     if (legacyLabelRegex.test(rawLabel)) {
       return this.legacyInterpolate(rawLabel, variables);
     }

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,7 @@ export class HistoryItemLabelProvider {`
`64`	`64`	`const rawLabel =`
`65`	`65`	`item.userSpecifiedLabel ?? (this.config.format \|\| "${queryName}");`
`66`	`66`
	`67`	`+ legacyLabelRegex.lastIndex = 0; // Reset the regex index to start searching from the start of the string if the strings are the same`
`67`	`68`	`if (legacyLabelRegex.test(rawLabel)) {`
`68`	`69`	`return this.legacyInterpolate(rawLabel, variables);`
`69`	`70`	`}`