Skip to content

Variant Analysis Results shows green check mark despite some failures #2239

Closed
@Marcono1234

Description

@Marcono1234

Describe the bug
The "REPOSITORIES" progress at the top of the Variant Analysis Results shows a green check mark despite the fact that the query failed for some projects:
Results screenshot

Version
Extension version:

CodeQL extension version: 1.8.1 
CodeQL CLI version: 2.12.5 
Platform: win32 x64

VS Code version:

Version: 1.76.2 (user setup)
Commit: ee2b180d582a7f601fa6ecfdad8d9fd269ab1884
Date: 2023-03-14T17:55:54.936Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Windows_NT x64 10.0.19045
Sandboxed: No

To reproduce

  1. Run a Variant Analysis query
  2. Cause the query to fail for some projects (?)
    Not sure if there is a proper way to reproduce this, in my case it failed due to "Request to https://objects-origin.githubusercontent.com/codeql-query-console returned status code 504" (action log)
  3. Open the Variant Analysis Results view and wait until all queries are completed
    ❌ Bug: The "REPOSITORIES" information at the top shows "100 / 100 ✔️"

Expected behavior
It should not show a green check mark, and maybe similar to a cancelled query run show a warning box informing the user that the query failed for some projects.

Metadata

Metadata

Assignees

No one assigned

    Labels

    VSCodebugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions