Skip to content

Crash when CodeQL evaluator log summary is too large #2787

Open
@dbartol

Description

@dbartol

Reported by several internal users:

[2023-09-06 14:13:16] Evaluation of .../code/ql/java/ql/src/Security/CWE/CWE-022/TaintedPath.ql produced BQRS results.
Error running query: Cannot create a string longer than 0x1fffffe8 characters (codeQL.quickEvalContextEditor)
Error: Error running query: Cannot create a string longer than 0x1fffffe8 characters
    at Object.slice (node:buffer:599:37)
    at Buffer.toString (node:buffer:819:14)
    at readFileHandle (node:internal/fs/promises:427:36)
    at generateSummarySymbols (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:144496:19)
    at generateSummarySymbolsFile (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:144492:19)
    at generateEvalLogSummaries (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:144889:7)
    at LocalQueryRun.summarizeEvalLog (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:145690:26)
    at LocalQueryRun.complete (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:145668:26)
    at LocalQueries.compileAndRunQueryInternal (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:146085:9)
    at LocalQueries.compileAndRunQuery (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:146025:5)
    at withProgress.title (~/.vscode/extensions/github.vscode-codeql-1.8.10/out/extension.js:145904:9)

The suspicion is that the log summary is too large to load as a single string, so we need to stream it.

Metadata

Metadata

Labels

VSCodebugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions