Skip to content

CodeQL CLI update dialog blocks extension start / update dialog is easy to miss #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marcono1234 opened this issue Jul 3, 2021 · 0 comments
Labels
bug Something isn't working VSCode

Comments

@Marcono1234
Copy link
Contributor

Describe the bug
Relates to #297, #447

When a CodeQL CLI update is available the start of the extension is blocked until the user interacted with the update dialog, see:

if (await helpers.showInformationMessageWithAction(updateAvailableMessage, 'Restart and Upgrade')) {
await commands.executeCommand('workbench.action.reloadWindow');

However, personally I think the info dialog shown by VSCode is easy to miss, especially when there are other dialogs from other extensions (and VSCode collapses the CodeQL dialog?).
When you then overlook CodeQL's dialog, you will wonder why the extension is not working.

Version
Extension:

CodeQL extension version: 1.5.1 
CodeQL CLI version: 2.5.7 
Platform: win32 x64

VSCode:

Version: 1.57.1 (user setup)
Commit: 507ce72a4466fbb27b715c3722558bb15afa9f48
Date: 2021-06-17T13:28:07.755Z
Electron: 12.0.7
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Windows_NT x64 10.0.19041

To reproduce

  1. Wait for the next CodeQL CLI release (maybe also possible with VSCode global storage manipulation)
  2. Start VSCode with the extension installed
  3. Activate the extension, for example by clicking on the "CodeQL" icon on the left sidebar
    ℹ️ The extension should show an info dialog about the CodeQL CLI update in the bottom right corner
  4. Ignore the update dialog (neither close it nor accept it)
  5. Try to use any extension action
    ❌ Nothing happens (note: from my memories; cannot test because there is no new CodeQL CLI release)

Expected behavior
Maybe the dialog should not be blocking and the extension should start with the existing CodeQL CLI?

@Marcono1234 Marcono1234 added the bug Something isn't working label Jul 3, 2021
@github-actions github-actions bot added the VSCode label Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VSCode
Projects
None yet
Development

No branches or pull requests

1 participant