Skip to content

Fix CSS file paths #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Fix CSS file paths #1055

merged 1 commit into from
Dec 17, 2021

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Dec 17, 2021

The CSS files are inside /view sub-directories so the paths are currently incorrect.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • @github/docs-content-codeql has been cc'd in all issues for UI or other user-facing changes made by this pull request.

@charisk charisk requested a review from a team as a code owner December 17, 2021 12:59
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this! Tested locally (and with the fresh build artifact from Actions)

I think we can just merge into main? Though it might be worth waiting till I've double-checked the process for release "hotfixes" 🤷🏽

@shati-patel shati-patel merged commit e1b35cd into main Dec 17, 2021
@shati-patel shati-patel deleted the charisk/fix-css-file-paths branch December 17, 2021 15:14
@aeisenberg
Copy link
Contributor

Good catch here! It definitely pays to do more manual testing of our features before releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants