MRVA: Add open on GitHub action to cancelled/failed queries #1325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed the "open on GitHub" action to cancelled/failed queries.
When a query fails, we set a value on the tree item to "cancelledResultsItem" (see here) - we then use that to decide whether to show the action or not. So the code could do with a bit of refactoring as it suggests that it only deals with cancelled queries, when in fact it deals with any failed queries. However, I won't be making that refactoring as part of this work.
Checklist
N/A:
ready-for-doc-review
label there.