Skip to content

MRVA: Add open on GitHub action to cancelled/failed queries #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Apr 29, 2022

Allowed the "open on GitHub" action to cancelled/failed queries.

When a query fails, we set a value on the tree item to "cancelledResultsItem" (see here) - we then use that to decide whether to show the action or not. So the code could do with a bit of refactoring as it suggests that it only deals with cancelled queries, when in fact it deals with any failed queries. However, I won't be making that refactoring as part of this work.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner April 29, 2022 07:36
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple but effective 😁 Thanks! 🚢

@charisk charisk merged commit 7d0d11f into main Apr 29, 2022
@charisk charisk deleted the charisk/canelled-view-on-github branch April 29, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants