Create diagnostics messages using sarif. #184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging 50fee61 into 0d7eb93 - view on LGTM.com new alerts:
|
alexet
force-pushed
the
alexet/sarif-problems
branch
from
50fee61 to
4d1e167
Compare
|
This pull request introduces 1 alert when merging 4d1e167 into e056c61 - view on LGTM.com new alerts:
|
alexet
force-pushed
the
alexet/sarif-problems
branch
from
4d1e167 to
4ebad72
Compare
|
This pull request introduces 2 alerts when merging 4ebad72 into e056c61 - view on LGTM.com new alerts:
|
alexet
force-pushed
the
alexet/sarif-problems
branch
from
4ebad72 to
6331092
Compare
|
This pull request introduces 1 alert when merging 6331092 into e056c61 - view on LGTM.com new alerts:
|
jcreedcmu
reviewed
Dec 3, 2019
| @@ -262,10 +263,31 @@ export class InterfaceManager extends DisposableObject { | |||
| sortedResultsMap, | |||
| database: info.database, | |||
| shouldKeepOldResultsWhileRendering, | |||
| kind: info.query.metadata ? info.query.metadata.kind : undefined | |||
| metadata: info.query.metadata | |||
There was a problem hiding this comment.
Passing along all of the metadata here instead of just kind seems like a good idea, though.
alexet
force-pushed
the
alexet/sarif-problems
branch
from
6331092 to
78e3612
Compare
|
This pull request introduces 1 alert when merging 78e3612 into 513d763 - view on LGTM.com new alerts:
|
alexet
force-pushed
the
alexet/sarif-problems
branch
2 times, most recently
from
09af48a to
cc9849e
Compare
alexet
force-pushed
the
alexet/sarif-problems
branch
from
cc9849e to
b1d6511
Compare
|
This code effectively landed in #222. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers a few edge cases not handled in the current support and removes a dependency from the typescript parsing code.