Skip to content

Fix rename that went too far #1988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fix rename that went too far #1988

merged 1 commit into from
Jan 19, 2023

Conversation

charisk
Copy link
Contributor

@charisk charisk commented Jan 18, 2023

It looks like I went a bit too far with the remote -> variantAnalysis rename (#1960) and accidentally renamed one of the domain entities 🤦 Since all others use remote, I decided to roll this one back.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk added the secexp label Jan 18, 2023
@charisk charisk requested review from a team as code owners January 18, 2023 17:21
norascheuch
norascheuch approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to rename all of those to variantAnalysis at some point though, right?.. (When?)

@charisk charisk force-pushed the charisk/fix-rename branch from caa8e09 to 3472a51 Compare January 19, 2023 08:31
@charisk
Copy link
Contributor Author

charisk commented Jan 19, 2023

We have to rename all of those to variantAnalysis at some point though, right?.. (When?)

I guess we don't have to so we have full control about when we chose to do that. I'm okay with the terms being different for a bit.

@charisk charisk merged commit 8a6b361 into main Jan 19, 2023
@charisk charisk deleted the charisk/fix-rename branch January 19, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norascheuch norascheuch norascheuch approved these changes

Assignees
No one assigned
Labels
secexp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charisk @norascheuch