Skip to content

Bump CLI Version to v2.13.1 for integration tests #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 4, 2023

Bumps CLI version from v2.13.0 to v2.13.1

@dbartol dbartol marked this pull request as ready for review May 4, 2023 18:13
@dbartol dbartol requested a review from a team as a code owner May 4, 2023 18:13
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the supported versions, but I guess that can happen in another PR.

@@ -1,5 +1,5 @@
[
"v2.13.0",
"v2.13.1",
"v2.12.7",
"v2.11.6",
"v2.7.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we still testing against 2.7.6? Shouldn't we be testing against 2.10.x instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh...ignore me. I didn't see that this file has 10 lines. I only saw the first 5.

Regardless, we only need to support the last 4 minor versions of the CLI.

@aeisenberg
Copy link
Contributor

Wait...why are all the jobs failing?

@aeisenberg aeisenberg enabled auto-merge May 5, 2023 23:07
@aeisenberg
Copy link
Contributor

Should be fixed after a merge with main.

@aeisenberg aeisenberg merged commit 3ad006d into main May 9, 2023
@aeisenberg aeisenberg deleted the github-action/bump-cli branch May 9, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants