Add command for restarting the query server. #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreedcmu
force-pushed
the
jcreed/restart-query-server
branch
from
8abc23f to
25ae6ed
Compare
Include a convenience button to show the query server log in case the reason the user wants to restart the server is that it's acting unexpectedly and they want to investigate why.
jcreedcmu
force-pushed
the
jcreed/restart-query-server
branch
from
25ae6ed to
71898ac
Compare
henrymercer
reviewed
Feb 25, 2020
There was a problem hiding this comment.
This command doesn't seem to behave very well when the extension hasn't been activated. To repro, ensure the QL sidebar icon is not selected, and ensure that a .ql or .qll file is not visible. Then run "CodeQL: Restart Query Server" from the command palette. The error message "command 'codeQL.restartQueryServer' not found" will be displayed.
It's not ideal, but an easy fix for this could be adding codeQL.restartQueryServer to the extension's activationEvents.
|
Yeah, no, good catch, it belongs in |
henrymercer
reviewed
Feb 25, 2020
henrymercer
previously approved these changes
Feb 25, 2020
Co-Authored-By: Henry Mercer <henry.mercer@me.com>
henrymercer
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a convenience button to show the query server log in case the
reason the user wants to restart the server is that it's acting
unexpectedly and they want to investigate why.
Fixes #243.
@github/product-docs-dsp: this adds a commandCodeQL: Restart Query Serverto the command palette.