Skip to content

Give visibility information to the ide-server. #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 28, 2023
Merged

Give visibility information to the ide-server. #2482

merged 4 commits into from
Jun 28, 2023

Conversation

alexet
Copy link
Contributor

@alexet alexet commented Jun 5, 2023

This should allow it to keep visible file up to date without the cost of checking all open files.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

aeisenberg
aeisenberg reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. If earlier versions of the CLI can silently ignore this message, then we probably don't need to guard the behaviour behind a version flag.

@alexet alexet marked this pull request as ready for review June 26, 2023 11:33
@alexet alexet requested a review from a team as a code owner June 26, 2023 11:33
@alexet alexet marked this pull request as draft June 26, 2023 11:33
@alexet alexet force-pushed the alexet/up-to-date-errors branch from 51e8897 to 2f18143 Compare June 26, 2023 11:36
@alexet alexet marked this pull request as ready for review June 26, 2023 11:41
@alexet
Copy link
Contributor Author

alexet commented Jun 26, 2023

This is merged on the cli side.

aeisenberg
aeisenberg approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like a merge conflict now that needs to be fixed.

@alexet alexet enabled auto-merge (squash) June 28, 2023 17:13
@alexet alexet merged commit 67d342f into main Jun 28, 2023
@alexet alexet deleted the alexet/up-to-date-errors branch June 28, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg

Assignees

@aeisenberg aeisenberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexet @aeisenberg