Throw error instead of using fail method #2536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we be using the

fail
method? We seem to be using it in a few tests to catch incorrect setup, so if everything is correct then this code path doesn't run. But when it does run it appears thefail
method isn't defined. See the following error:I haven't looked deeply into this yet, so I'm not sure if there's something else causing the above failure and maybe we do still want to use
fail
. But I wonder is there any downside to throwing an exception in any of these cases instead?Checklist
ready-for-doc-review
label there.