Skip to content

Relax 'resolve ram' test #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Relax 'resolve ram' test #2805

merged 1 commit into from
Sep 12, 2023

Conversation

nickrolfe
Copy link
Contributor

The test currently assumes that the CLI will use an exact 50/50 split between heap and off-heap RAM, but this is not guaranteed. Relax the test so that it doesn't care about the specific numbers.

The test currently assumes that the CLI will use an exact 50/50 split
between heap and off-heap RAM, but this is not guaranteed. Relax the
test so that it doesn't care about the specific numbers.
@nickrolfe nickrolfe marked this pull request as ready for review September 12, 2023 10:48
@nickrolfe nickrolfe requested a review from a team as a code owner September 12, 2023 10:48
Copy link
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 🌷

@shati-patel shati-patel merged commit acf7270 into main Sep 12, 2023
@shati-patel shati-patel deleted the nickrolfe/relax-test branch September 12, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants