Bump minimum VS Code version to 1.82 #2854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
MIN_VERSIONthat will be used for showing warnings to1.82.0. 1.82 is the August release (currently the latest) and upgrades to Node.js 18. We would like to be able to upgrade to dependencies that require Node.js 18, so let's set the minimum supported version to this so we can drop support for older versions after the next release.We can't really upgrade to a newer VS Code version for integration tests until we fully support Node.js 18, but that means dropping support for running integration tests on Node.js 16. Therefore, we need to merge this before doing our upgrade to a newer VS Code and Node.js version.
Checklist
ready-for-doc-reviewlabel there.