Skip to content

Use codeql.exe instead of codeql.cmd on Windows #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Use codeql.exe instead of codeql.cmd on Windows #286

wants to merge 2 commits into from

Conversation

nickrolfe
Copy link
Contributor

Draft: seeing if it affects actions.

@aeisenberg
Copy link
Contributor

Thanks for putting this up. This looks fine to me. What's the purpose of the codeql.cmd file? Looks like a thin wrapper around the exe. Is it just legacy?

@nickrolfe
Copy link
Contributor Author

At this point it's just legacy.

In the first release of the CodeQL CLI, there was no .exe and all the launcher logic was in codeql.cmd (mirroring the shell script used on Linux and Mac), but this was difficult to maintain and didn't always work reliably for me in PowerShell, so we wrote a C++ launcher executable and made the .cmd version a thin wrapper around that.

I already tried making these changes with #211, but we had to revert that until we'd be sure all used had updated to a recent CLI that included the .exe.

aeisenberg
aeisenberg requested changes Mar 16, 2020
View reviewed changes
.github/workflows/main.yml Outdated
@@ -80,7 +80,7 @@ jobs:
if: matrix.os == 'windows-latest'
run: |
cd extensions/ql-vscode
$env:CODEQL_PATH=$(Join-Path $env:GITHUB_WORKSPACE -ChildPath 'codeql-home/codeql/codeql.cmd')
$env:CODEQL_PATH=$(Join-Path $env:GITHUB_WORKSPACE -ChildPath 'codeql-home/codeql/exe.cmd')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean codeql.exe.

@aeisenberg aeisenberg force-pushed the codeql.exe2 branch 6 times, most recently from 14c7609 to a0dfcbf Compare March 16, 2020 22:56
@aeisenberg
Copy link
Contributor

I cherry-picked the changes here into #284. Closing this one.

@aeisenberg aeisenberg closed this Mar 16, 2020
@aeisenberg
Copy link
Contributor

The failing build appears to only affect 2.0.5. Now that 2.0.6 is out, the build is passing. Perhaps, it was a windows defender issue.

@aeisenberg aeisenberg deleted the codeql.exe2 branch November 24, 2020 22:26
@CxsLucyfer CxsLucyfer mentioned this pull request Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg

Copilot code review Copilot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickrolfe @aeisenberg