Remove ownerName and repositoryName from DistributionConfig #3183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, these fields do not work. They aren't linked up to read values from the config, and setting
"codeQL.cli.repositoryName": "foo"
in your config does nothing.This reason for this is because the only way these values are accessed is through the
DistributionConfigListener
class, which implements theDistributionConfig
interface. That class does not define these fields and therefore they get their default value ofundefined
. The reason we didn't notice this earlier is because the field is allowed to beundefined
. If you change the type tostring | null
then it produces an error.Looking back in the history, I believe the intention was to fully remove these in #174 (see the comments on the linked internal issues) but for whatever reason that PR didn't remove all references and instead only marked them as maybe undefined. I'm a little confused by that, but I think that removing these final references does not change behaviour and is in the spirit of that earlier change.
Checklist
ready-for-doc-review
label there.