Skip to content

Compare performance: Detect 'shadowed' cache hits and a few other fixes #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 30, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update dependencies passed to useMemo
  • Loading branch information
asgerf committed Apr 25, 2025
commit 0da5e5b7574cf62b11ebdd77d605c18733974ead
Original file line number Diff line number Diff line change
@@ -625,7 +625,17 @@ function ComparePerformanceWithData(props: {
})
.filter((x) => !!x)
.sort(getSortOrder(sortOrder));
}, [keySet, from, to, metric, hideCacheHits, sortOrder, isPerEvaluation]);
}, [
keySet,
from,
to,
metric,
hideCacheHits,
sortOrder,
isPerEvaluation,
shadowedCacheHitsFrom,
shadowedCacheHitsTo,
]);

const { totalBefore, totalAfter, totalDiff } = useMemo(() => {
let totalBefore = 0;
Loading
Oops, something went wrong.