Skip to content

Compare performance: Detect 'shadowed' cache hits and a few other fixes #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Apr 30, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
  • Loading branch information
asgerf and aeisenberg authored Apr 29, 2025
commit f9f92462b7ee6fcc217af1b98eb6e4ccf8a8afd3
Original file line number Diff line number Diff line change
@@ -124,7 +124,7 @@ export class PerformanceOverviewScanner implements EvaluationLogScanner {
case "COMPUTED_EXTENSIONAL": {
if (predicateName.startsWith("cached_")) {
// Add a dependency from a cached COMPUTED_EXTENSIONAL to the predicate with the actual contents.
// The raHash of the this event may appear in a CACHE_HIT events in the other event log. The dependency
// The raHash of the this event may appear in a CACHE_HIT event in the other event log. The dependency
// we're adding here is needed in order to associate the original predicate with such a cache hit.
const originalName = predicateName.substring("cached_".length);
const originalIndex = this.nameToIndex.get(originalName);
Original file line number Diff line number Diff line change
@@ -159,7 +159,7 @@ class ComparisonDataset {
const name = other.data.names[otherCacheHit];
const ownIndex = this.nameToIndex.get(name);
if (ownIndex != null) {
visit(ownIndex, this.data.raHashes[ownIndex]);
visit(ownIndex, raHashes[ownIndex]);
}
}
}
Loading
Oops, something went wrong.