Allow viewing SARIF from query history view #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcreedcmu
changed the title
aeisenberg
reviewed
May 27, 2020
| // Mark this query history item according to whether it has a | ||
| // SARIF file so that we can make context menu items conditionally | ||
| // available. | ||
| it.contextValue = element.query.hasInterpretedResults() ? 'interpretedResultsItem' : 'rawResultsItem'; |
| * Holds if this query actually has produced interpreted results. | ||
| */ | ||
| hasInterpretedResults(): boolean { | ||
| return fs.existsSync(this.resultsPaths.interpretedResultsPath); |
There was a problem hiding this comment.
Can we make this function async? Otherwise, this is blocking.
There was a problem hiding this comment.
Ah, I was afraid the getTreeItem had to be synchronous, but it looks like vscode permits it to return a Promise. Happy to make it async then.
|
And looks like the unit tests caught a legitimate issue that would have been hard to find otherwise. Nice. :) |
Ah, right, I did leave out the command palette exclusion to see if it would trigger that, then promptly forgot that I had done so. Thankfully, unit tests don't forget :) |
aeisenberg
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the SARIF part of #342. Could still use CSV export.
@github/product-docs-dspany need for docs for this?