Prevent custom definitions to be loaded when DB is not up-to-date

[cedric-anne]

Checklist before requesting a review

• I have read the CONTRIBUTING document.
• I have performed a self-review of my code.

Description

When a DB update is required, the custom objects autoloader is not registered and the definitions are not booted. However, the AssetDefinitionManager::getDefinitions() method returns all the definitions founds in the database, due to its "on demand" loading mechanism.

It can cause issues. For instance, when the plugins are deactivated when a DB update is required, Plugin->unactivateAll() is executed and indirectly tries to load the asset definitions (Glpi\Event::log() -> CommonDBTM->add() -> Webhook::raise() -> Webhook::getAPIItemtypeData() -> Glpi\Api\HL\Controller\CustomAssetController::getCustomAssetTypes() -> Glpi\Asset\AssetDefinitionManager->getDefinitions()), and then tries to call the getTypeName() method on corresponding classes, than cannot be loaded because the custom asset classes autoloader is not registered.

glpi.CRITICAL:   *** Uncaught Error: Class "Glpi\CustomAsset\PortableAsset" not found
  Backtrace :
  ...Api/HL/Controller/CustomAssetController.php:292 
  ./src/Webhook.php:363                              Glpi\Api\HL\Controller\CustomAssetController::getCustomAssetTypes()
  ./src/Webhook.php:1104                             Webhook::getAPIItemtypeData()
  ./src/CommonDBTM.php:1442                          Webhook::raise()
  ./src/Glpi/Event.php:129                           CommonDBTM->add()
  ./src/Plugin.php:1304                              Glpi\Event::log()
  ...ener/PostBootListener/CheckPluginsStates.php:76 Plugin->unactivateAll()
  .../event-dispatcher/Debug/WrappedListener.php:116 Glpi\Kernel\Listener\PostBootListener\CheckPluginsStates->onPostBoot()
  ...ymfony/event-dispatcher/EventDispatcher.php:220 Symfony\Component\EventDispatcher\Debug\WrappedListener->__invoke()
  ...symfony/event-dispatcher/EventDispatcher.php:56 Symfony\Component\EventDispatcher\EventDispatcher->callListeners()
  ...spatcher/Debug/TraceableEventDispatcher.php:139 Symfony\Component\EventDispatcher\EventDispatcher->dispatch()
  ./src/Glpi/Kernel/Kernel.php:144                   Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher->dispatch()
  ./vendor/symfony/http-kernel/Kernel.php:192        Glpi\Kernel\Kernel->boot()
  ./public/index.php:70                              Symfony\Component\HttpKernel\Kernel->handle()

I think the root issue here is that CommonDBTM::add() is executed on a GLPI instance that requires an update. However, changing this is probably complex, and probably requires some specifications. Indeed, we want to keep the event log (both in DB and in files) for the changes made on the plugins states during the GLPI bootstrap. A solution could be to disable the add/update/delete hooks on the event log, but it is too late to do it in GLPI 11.0.