Ursa 21.14.0 plat 25213 #13265
Open
Ursa 21.14.0 plat 25213 #13265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugins/scheduled_task/batch/ScheduledTaskRunner/KScheduledTaskRunner.class.php
Outdated
Show resolved
Hide resolved
plugins/scheduled_task/batch/ScheduledTaskRunner/KScheduledTaskRunner.class.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new scheduling function in the scheduled task runner to index tasks per partner and adds a safety check in the generic scheduler to ensure indexes are iterated only when in array format.
- Added getMrIndexPerPartner() to compute a task index based on partnerId for scheduling.
- Inserted a logging statement for debugging task execution and included an explicit guard for non-array index values in the scheduler.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/scheduled_task/batch/ScheduledTaskRunner/KScheduledTaskRunner.class.php | Introduces helper method to calculate the partner-specific task index and adds logging in run() |
| batch/scheduler/KGenericScheduler.class.php | Wraps the non-array check for task indexes in braces for clarity |
| $mrNumberOfWorkers = $this->getParams('mrNumberOfWorkers'); | ||
| if($mrNumberOfWorkers) | ||
| { | ||
| $index = ($partnerId / 10) % $mrNumberOfWorkers; |
There was a problem hiding this comment.
Consider explicitly casting ($partnerId / 10) to an integer before applying the modulo to ensure the arithmetic behaves as expected, since PHP division returns a float.
Suggested change
| $index = ($partnerId / 10) % $mrNumberOfWorkers; | |
| $index = (int)($partnerId / 10) % $mrNumberOfWorkers; |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.