Ursa 21.16.0 plat 25124 - IPv6 Support #13314
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces IPv6 support by replacing outdated ip2long() calls with a new utility method (kIpAddressUtils::ipToLong) and enhancing IP range and mask handling logic. Key changes include:
- Replacing ip2long() with kIpAddressUtils::ipToLong() in multiple scripts and model files.
- Extending kIpAddressUtils to support IPv6 conversions, comparisons, and CIDR calculations.
- Adding comprehensive tests to verify IPv6 functionality across various components.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| deployment/base/scripts/DigitalElement/convertAnonymousCsvToBin.php | Updated IP conversion to use IPv6-compatible method. |
| alpha/scripts/uv_summary_insert.php | Updated IP conversion for improved IPv6 support. |
| alpha/scripts/analyze_collect_stats.php | Updated IP conversion to support IPv6. |
| alpha/lib/model/WidgetLog.php | Updated IP conversion for IPv6 support. |
| alpha/apps/kaltura/lib/requestUtils.class.php | Updated IP conversion for IPv6 support. |
| alpha/apps/kaltura/lib/request/kIpAddressUtils.php | Enhanced to support IPv6 with new utility methods and logic updates. |
| alpha/apps/kaltura/lib/request/ipv6Test.php | Added tests ensuring IPv6 conversion, range checking, and validations. |
| alpha/apps/kaltura/lib/request/infraRequestUtils.class.php | Updated IP conversion; note a potential issue with method resolution for ipToLong. |
| alpha/apps/kaltura/lib/kDigitalElementIPGeoCoder.php | Updated IP conversion for IPv6 support. |
| if ($longIp && $longIp != -1) | ||
| { | ||
| foreach ($privateRanges as $range) | ||
| { | ||
| list($start, $end) = explode('|', $range); | ||
| if ($longIp >= ip2long($start) && $longIp <= ip2long($end)) { | ||
| // Replace ip2long with ipToLong to support both IPv4 and IPv6 | ||
| if ($longIp >= self::ipToLong($start) && $longIp <= self::ipToLong($end)) { |
There was a problem hiding this comment.
The code uses self::ipToLong() inside infraRequestUtils, but ipToLong is defined in kIpAddressUtils. Update the call to kIpAddressUtils::ipToLong() to ensure proper IPv6 support.
Suggested change
| if ($longIp >= self::ipToLong($start) && $longIp <= self::ipToLong($end)) { | |
| if ($longIp >= kIpAddressUtils::ipToLong($start) && $longIp <= kIpAddressUtils::ipToLong($end)) { |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.