PSVAMB-85314 -> Support SignLanguage ratio display in the partner cat… #13371
Conversation
…alog item list also
|
@github-copilot suggest |
| @@ -59,8 +59,16 @@ | |||
| else | |||
| echo null;?> | |||
| </td> | |||
| <td><?php if (isset($catalogItem->outputFormat)) | |||
| echo $this->enumTranslate('Kaltura_Client_Reach_Enum_VendorCatalogItemOutputFormat', $catalogItem->outputFormat); | |||
| <td><?php if (isset($catalogItem->outputFormat)) { | |||
There was a problem hiding this comment.
Why isn't VendorCatalogItemSignLanguageOutputFormat an extension of VendorCatalogItemOutputFormat
This would remove the need if this if and will make much more sense
There was a problem hiding this comment.
But the values for both VendorCatalogItemSignLanguageOutputFormat and VendorCatalogItemOutputFormat are the same, the only difference is the view in the KAC
For example in catalog item list:
There was a problem hiding this comment.
This implements base enum
Whereas it could extend this:
That way you dont need this if
There was a problem hiding this comment.
@yossipapi I think it's better to eliminate KalturaVendorSignLanguageFormat, and add the 2 new values to the base enum, since this is part of the base reach capability anyway. Keeping the enum and making it extend the base class risks overlap of enum values in the future.
…alog item list also