-
Notifications
You must be signed in to change notification settings - Fork 655
[E-Document Core] - Sending E-document file via service and an email in parallel. Create E-document from Posted Sales Invoice #28099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[E-Document Core] - Code workspace
…i/EmailEDocsOnSalesPostAndSend
BindSubscription(EDocImplState); | ||
|
||
// [GIVEN] Sales order | ||
LibraryLowerPermission.SetTeamMember(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the LibraryLowerPermisson here.
A team member migth be able to create sales order currently, but isn't a team member restricted to only create quotes with the license?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed it to be SalesDocsPost permission
local procedure CreateSourceLists( | ||
ToCust: Code[20]; | ||
var SourceReference: RecordRef; | ||
SourceTableIDs: List of [Integer]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would reccomend to set var
explicit to the reference types here, too.
@Groenbech96 @GMatuleviciute this build will fail as it requires the base app modification to be in place |
PR is still on hold until https://github.com/microsoft/BusinessCentralApps/pull/1185 has been merged. |
@Groenbech96 Related base app pull request is approved and merged. This pull request is ready for review. |
This pull request does not have a related issue as it's part of the delivery for development agreed directly with @altotovi @Groenbech96
Implementation 1
With this update E-Documents are automatically created and emailed, when posting Sales Invoices, Sales Orders, and Sales Credit Memos.
When the user clicks on "Post" ->"Post and Send" action:
This feature improves efficiency by reducing manual tasks and ensuring timely e-document distribution.
Implementation 2
Another newly implemented E-Documents feature enables users to generate an E-Document from a posted Sales Invoice or Credit Memo, even if the customer’s setup was incomplete at the time of posting.
This enhancement allows users to generate an E-Document from a posted Sales document if the customer configuration regarding "Document Sending Profile" has been updated post-posting.
New Action under Related-> E-Document-> Other Menu in Posted Sales Invoice/Credit Memo card page:
Another new Action is added under Print/Send Menu in Posted Sales Invoice/Credit Memo card page:
In this way, user can get the E-Document through different channels for their convenience.
Related with Base App modification: Replace Temp Server File with TempBlob for Report Email Body by pri-kise · Pull Request #1185 · microsoft/BusinessCentralApps
Fixes #