[E-Document] Fornav.edoc.init #28554
Conversation
|
@microsoft-github-policy-service agree [company="{FORNAV}"] |
|
@microsoft-github-policy-service agree company="FORNAV" |
|
@renebrummel build is failing. Can you take a look |
Apps/W1/EDocumentConnectors/FORNAV/app/src/ForNAV/AppRespHandler.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentConnectors/FORNAV/app/src/ForNAV/AppRespHandler.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentConnectors/FORNAV/app/src/ForNAV/IncomingDoc.Table.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentConnectors/FORNAV/app/src/ForNAV/IncomingDocStatus.enum.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentConnectors/FORNAV/app/src/ForNAV/IncomingDocsApi.Page.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentConnectors/FORNAV/app/src/ForNAV/IncomingDocsApi.Page.al
Outdated
Show resolved
Hide resolved
Apps/W1/EDocumentConnectors/FORNAV/app/src/ForNAV/IncomingDocsApi.Page.al
Outdated
Show resolved
Hide resolved
|
@renebrummel more failures :) |
Fixed, it does not help that the codecop warning is hidden by default. |
| var | ||
| PeppolJobQueue: Codeunit "ForNAV Peppol Job Queue"; | ||
| PeppolOauth: Codeunit "ForNAV Peppol Oauth"; | ||
| begin |
There was a problem hiding this comment.
I think that it isn't a good practice to automatically create Job queue entries when the app is installed or upgraded.
Since the code not only only creates the job queue, but also enqueues the job queue this will fail if an the Installation/Upgrade is performend by a GDAP user.
| SendContext: Codeunit SendContext; | ||
| HttpRequest: HttpRequestMessage; | ||
| HttpResponse: HttpResponseMessage; | ||
| SendApproveRejectCheckStatusErr: Label 'You cannot send %1 response with the E-Socument in this current status %2. You can send response when E-document status is ''Imported Document Created''.', Comment = '%1 - Action response, %2 - Status', Locked = true; |
There was a problem hiding this comment.
Why is this lable locked?
This will prevent the translation of this error message?
|
|
||
| var | ||
| ForNAVAPIRequests: Codeunit "ForNAV API Requests"; | ||
| UnsuccessfulResponseErr: Label 'There was an error sending the request. Response code: %1 and error message: %2', Comment = '%1 - http response status code, e.g. 400, %2- error message', Locked = true; |
There was a problem hiding this comment.
Why are those error labels locked?
This will prevent the translation.
| procedure ObtainPrivacyConsent(): Boolean | ||
| var | ||
| CustConsentMgt: Codeunit "Customer Consent Mgt."; | ||
| CustomConsentMessageLbl: Label 'Please agree to the ForNAV EULA: https://www.fornav.com/documents/EULA.pdf', Locked = true; |
There was a problem hiding this comment.
Why is this label locked? This will prevent the translation.
| EDocumentLogHelper.InsertLog(EDocument, EDocumentService, TempBlob, "E-Document Service Status"::Imported); | ||
| end; | ||
|
|
||
| local procedure GetEdocumentService() EDocumentService: Record "E-Document Service" |
There was a problem hiding this comment.
We shouldn't depend on the name FORNAV for the E-Document Service.
| jLicense.Add('EnvironmentName', EnvironmentInformation.GetEnvironmentName()); | ||
| end else | ||
| jLicense.Add('SerialNumber', Database.SerialNumber); | ||
| if NavApp.GetModuleInfo('63ca2fa4-4f03-4f2b-a480-172fef340d3f', AppModuleInfo) then |
There was a problem hiding this comment.
Which appId is this?
Should this be the AppId of the current app?
| field(Code; Rec."Identification Code") | ||
| { | ||
| ApplicationArea = All; | ||
| ToolTip = 'Specifies the Identification Code.', Locked = true; |
There was a problem hiding this comment.
The ToolTips here shouldn't be locked.
Furthermore they could be moved to the table.
| TempBlob: Codeunit "Temp Blob"; | ||
| AzureADTenant: Codeunit "Azure AD Tenant"; | ||
| EnvironmentInformation: Codeunit "Environment Information"; | ||
| BodyText: BigText; |
There was a problem hiding this comment.
Instead of BigText for String Concatenation it's recommend to use a TextBuilder.
| exit('********'); | ||
| end; | ||
|
|
||
| [BusinessEvent(false)] |
There was a problem hiding this comment.
This looks incorrect for me.
Why is this procedure marked as a BusinessEvent?
| using Microsoft.Foundation.Reporting; | ||
| using System.Automation; | ||
|
|
||
| table 6414 "ForNAV Peppol Setup" |
There was a problem hiding this comment.
The caption for this table and for the fields in this objet sholdn't be locked that those are translated.
Summary Added FORNAV Peppol App
Work Item(s)
Fixes #28553
Fixes AB#572834