Skip to content

[Shopify] Connector - Market Catalogs #28742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

GediminasGaubys
Copy link
Contributor

This pull request does not have a related issue as it's part of the delivery for development agreed directly with @AndreiPanko

Market Catalogs implementation:

  • Page "Shop Card" - added new action to open Market Catalogs for the shop
  • Table 30152 "Shpfy Catalog" - new fields "Catalog Type", "Currency Code" added
  • Page 30159 "Shpfy Catalogs":
    Changed page caption to 'Shopify B2B Catalogs'
    Added functioanlity to set Catalog Type
    Added filtering OnOpenPage
  • New page 30171 "Shpfy Market Catalogs" is created with the filter to show only Market Catalogs
  • Report 30116 "Shpfy Sync Catalog Prices":
    Adjusted current functionality to be compatible for different kind of Shopify Catalogs (Company, Market)
  • Report 30115 "Shpfy Sync Catalogs"
    Adjusted current functionality to be compable for different kind of Shopify Catalogs (Company, Market)
  • New enum 30167 "Shpfy Catalog Type" created to classify different kind of Shopify catalogs (Company, Market)
  • Codeunit "Shpfy Catalog API":
    Implemented new procedures GetMarketCatalogs(), ExtractShopifyMarketCatalogs(), GetMarketsLinkedToCatalog(), ExtractMarketsLinkedToCatalog()
    Adjusted GetMarketCatalogProductsURL() procedure to get Shopify URL for market catalogs products
  • Codeunit 30101 "Shpfy Background Syncs" - extended internal procedure CatalogPricesSync() to manage market catalogs prices
  • Codeunit 30182 "Shpfy Product Price Calc." - Added additional functionality for procedure CreateTempSalesHeader() to set "Currency Code" from Market Catalog
  • Codeunit 30106 "Shpfy Upgrade Mgt." - Added procedure to update existing catalogs by assigning Catalog Type 'Company'

New GraphQLs created:

  • codeunit 30400 "Shpfy GQL Market Catalogs" (enum 30111 "Shpfy GraphQL Type"::GetMarketCatalogs) (incl. Currency Code)
  • codeunit 30401 "Shpfy GQL NextMarketCatalogs" (enum 30111 "Shpfy GraphQL Type"::GetNextMarketCatalogs) (incl. Currency Code)
  • codeunit 30402 "Shpfy GQL Catalog Markets" (enum 30402 "Shpfy GraphQL Type"::GetMarketCatalogs)
  • codeunit 30403 "Shpfy GQL NextCatalogMarkets"
  • Enum 30111 "Shpfy GraphQL Type" - added new Enum values as new implementation for Market Catalogs

codeunit 30103 "Shpfy Communication Mgt." - Increased API Version to 2025-04

New automated Tests (codeunit 139542 "Shpfy Market Catalog API Test"):
- Extract Shopify Market Catalogs

Other Fixes:

  • Proceudre GetCatalogProductsURL() (codeunit "Shpfy Catalog API") doesn't work properly - returns incorrect Shop Name due to TrimStart function behavior. Switched to Replace function.
  • Proceudre ExtractShopifyCatalogs() (codeunit "Shpfy Catalog API") doesn't work properly - it doesn't update catalogs information because Modify() is after FindFirst()

@GediminasGaubys GediminasGaubys requested a review from a team as a code owner June 6, 2025 09:23
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration GitHub request for Integration area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants