Skip to content

Add shproj and projitems extensions to monaco_languages.json #39246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rezanid
Copy link

@rezanid rezanid commented May 5, 2025

Both ".shproj" and ".projitems" are extensions using by Microsoft Visual Studio for Shared Projects. The files are standard XML.

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

This PR simply adds two new extensions to XML for Monaco preview. Both extensions are known by Visual Studio.

Validation Steps Performed

No automated test. Monaco has a configuration file that works like a dictionary to define supported languages and their extensions. I added the two extensions to this file for XML language.

Both ".shproj" and ".projitems" are extensions using by Microsoft Visual Studio for Shared Projects. The files are standard XML.
@PesBandi
Copy link
Contributor

PesBandi commented May 5, 2025

Hi @rezanid, monaco_languages.json is a generated file. Your contribution would get overwritten the next time someone regenerates it. In order to properly add support for the new extensions you need to add them in monacoSpecialLanguages.js (see the docs).

@rezanid
Copy link
Author

rezanid commented May 5, 2025

Hi @PesBandi, thanks for your quick feedback. Good piece of info! I will correct it.

Copy link
Member

@crutkas crutkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see @PesBandi comment as this would be overwritten

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants