[peek, explorer] Update QOI reader for 3-channel images #39304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbartlett21
changed the title
|
Also, some feedback on developing, it would be good to have a note that I may need to enable long paths in order to build PowerToys. (It results in all sorts of various errors while building). |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the QOI reader for 3-channel images by adjusting the reading algorithm to account for bitmap row length (which must be a multiple of 4). Key changes include introducing a pixel position counter and a row padding adjustment to align data correctly with the bitmap stride.
Comments suppressed due to low confidence (1)
src/common/FilePreviewCommon/QoiImage.cs:160
- [nitpick] Consider renaming 'x' to a more descriptive name like 'pixelX' or 'currentColumn' to improve readability.
x++;
lei9444
approved these changes
May 29, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Make sure we account for Bitmap row length being a multiple of 4 when reading Qoi files.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Built and run and restarted file explorer.
Sample files from my comment on the issue (after rewriting each one to force the thumbnail to regenrate):