workspaces: shell:appsfolder launch does not support the command line #39433
Conversation
vanzue
changed the title
vanzue
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| { | ||
| Logger::trace(L"Launching {} as {}", app.name, app.appUserModelId); | ||
| auto res = LaunchApp(L"shell:AppsFolder\\" + app.appUserModelId, app.commandLineArgs, app.isElevated); | ||
| auto res = LaunchApp(app.appUserModelId, app.commandLineArgs, app.isElevated); |
There was a problem hiding this comment.
Previously, if it launch with "shell:appFolder\" way, actually the comandLineArgs mean nothing since it doesn't support passing any app's args..
NOTE: I don't mean it need to be investigate or fix anything in current PR, I mean with this fix, it may, not sure if there must be, open a possibility to support "args" in case a particular steam://XXX support args as part of this URL.
There was a problem hiding this comment.
Make sense, will take a look afterwards
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression in launching Steam games by restricting the scope for shell:appsfolder launches when command line arguments are not supported. Key changes include introducing a Steam protocol prefix constant and modifying the launch logic for apps with an appUserModelId.
- Added a new constant for Steam protocol detection.
- Updated the launch condition and logic to directly launch Steam games without prepending "shell:AppsFolder\".
Comments suppressed due to low confidence (1)
src/modules/Workspaces/WorkspacesLauncher/AppLauncher.cpp:139
- There is an inconsistency in referencing the Steam protocol prefix. A new constant 'SteamProtocolPrefix' was introduced, yet this line refers to 'NonLocalizable::SteamProtocolPrefix'. Consider updating the reference to use the newly declared constant.
if (!launched && !app.appUserModelId.empty() && app.appUserModelId.contains(NonLocalizable::SteamProtocolPrefix))
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…#39433) shell:appsfolder launch does not respect the command line
…microsoft#39433) shell:appsfolder launch does not respect the command line
Fix #39427
Summary of the Pull Request
Fix a regression when supporting steam games launch in workspaces by this PR #38380
Try to launch steam game with shell:\appsfolder/appusermodelid
When doing release check, use terminal as the "command line testing app", that works fine, so missed this one.
This pr restrict the scope of specific launch case for steam games
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Locally verified for edge and visual studio, and make sure steam games still work
#39427