CmdPal: Don't trim the template proj in debug builds #39463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
added
Needs-Review
|
I noticed the same, but decided to keep it. How "safe" is to trim only when compiled in release mode? |
|
This is vaguely inspired by this block out of the WinAppSdk project templates: <!-- Publish Properties -->
<PropertyGroup>
<PublishReadyToRun Condition="'$(Configuration)' == 'Debug'">False</PublishReadyToRun>
<PublishReadyToRun Condition="'$(Configuration)' != 'Debug'">True</PublishReadyToRun>
<PublishTrimmed Condition="'$(Configuration)' == 'Debug'">False</PublishTrimmed>
<PublishTrimmed Condition="'$(Configuration)' != 'Debug'">True</PublishTrimmed>
</PropertyGroup>I assumed setting <IsAotCompatible>true</IsAotCompatible>would leave things checked for being AoT (including trim) safe, but I'm clearly off my rocker. https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/prepare-libraries-for-trimming Looks like we want <PropertyGroup Condition="'$(Configuration)'=='Debug'">
<IsAotCompatible>false</IsAotCompatible>
<PublishTrimmed>false</PublishTrimmed>
<EnableTrimAnalyzer>true</EnableTrimAnalyzer>
<EnableSingleFileAnalyzer>true</EnableSingleFileAnalyzer>
<EnableAotAnalyzer>true</EnableAotAnalyzer>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)'!='Debug'">
<PublishTrimmed>true</PublishTrimmed>
<IsAotCompatible>true</IsAotCompatible>
</PropertyGroup>i think? |
DHowett
reviewed
May 15, 2025
| <CsWinRTAotOptimizerEnabled>true</CsWinRTAotOptimizerEnabled> | ||
| <CsWinRTAotWarningLevel>2</CsWinRTAotWarningLevel> | ||
| <!-- Suppress DynamicallyAccessedMemberTypes.PublicParameterlessConstructor in fallback code path of Windows SDK projection --> | ||
| <WarningsNotAsErrors>IL2081</WarningsNotAsErrors> | ||
| <WarningsNotAsErrors>IL2081;$(WarningsNotAsErrors)</WarningsNotAsErrors> |
DHowett
approved these changes
May 15, 2025
I would very much like that. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zadjii-msft
added a commit
that referenced
this pull request
May 16, 2025
Squashed commit of the following: commit 3fb7ebe Author: Mike Griese <migrie@microsoft.com> Date: Thu May 15 16:38:17 2025 -0500 update template commit 167266a Author: Mike Griese <migrie@microsoft.com> Date: Thu May 15 16:37:46 2025 -0500 More correct commit fa672c6 Author: Mike Griese <migrie@microsoft.com> Date: Thu May 15 10:23:31 2025 -0500 add template zip commit 97205ea Author: Mike Griese <migrie@microsoft.com> Date: Thu May 15 10:22:51 2025 -0500 CmdPal: Don't trim in debug for template
|
this good to go? |
michaeljolley
removed
the
Needs-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves a LOT of compilation time