Skip to content

CmdPal: Improving order of results from settings search #39525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

michaeljolley
Copy link
Contributor

The search results when finding settings with $ was sorted alphabetically. Updated this behavior to sort them based on relevance to the query.

Original search results with query provided in issue:
image

New search results with query provided in original issue:
Image

Example of results when giving a query that matches many, but is also an exact match.
Image

Closes #38615

@michaeljolley michaeljolley added Needs-Review This Pull Request awaits the review of a maintainer. Product-Command Palette Refers to the Command Palette utility labels May 16, 2025
@michaeljolley michaeljolley requested a review from zadjii-msft May 16, 2025 22:26
@michaeljolley michaeljolley changed the title Improving order of results from settings search CmdPal: Improving order of results from settings search May 16, 2025
@michaeljolley michaeljolley requested a review from DHowett May 22, 2025 01:11
@michaeljolley michaeljolley requested review from moooyo and vanzue June 5, 2025 00:47
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck yeah

@michaeljolley michaeljolley merged commit 4f3f7d6 into main Jun 6, 2025
16 checks passed
@michaeljolley michaeljolley deleted the dev/mjolley/improve-settings-search-order branch June 6, 2025 19:58
@yeelam-gordon yeelam-gordon removed the Needs-Review This Pull Request awaits the review of a maintainer. label Jun 9, 2025
@yeelam-gordon yeelam-gordon added this to the PowerToys 0.92 milestone Jun 9, 2025
sadirano pushed a commit to sadirano/PowerToys that referenced this pull request Jun 10, 2025
)

The search results when finding settings with `$` was sorted
alphabetically. Updated this behavior to sort them based on relevance to
the query.

Original search results with query provided in issue:

![image](https://github.com/user-attachments/assets/7ffd41bc-42d4-46fe-925e-aed7d7d04f3f)

New search results with query provided in original issue:

![Image](https://github.com/user-attachments/assets/ab47fc25-9b90-4cc7-b476-253b23cee6f9)

Example of results when giving a query that matches many, but is also an
exact match.

![Image](https://github.com/user-attachments/assets/59982f41-d27c-4582-9b01-9a5683a26819)

Closes microsoft#38615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Command Palette Refers to the Command Palette utility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CmdPal: weighting within Windows Settings search is not very good
3 participants