Skip to content

[Settings] String updates and minor UX tweaks #40249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[Settings] String updates and minor UX tweaks #40249

wants to merge 9 commits into from
+129 −145

Conversation

niels9001
Copy link
Contributor

@niels9001 niels9001 commented Jun 26, 2025 •
edited
Loading

Summary of the Pull Request

  • I asked Copilot nicely to rewrite some of our strings to be inline with the Windows writing style guide and to be less verbose or provide a better explaination.
  • Since the Sound expander on the Always on Top page had a single setting, turning that into a card.

Before:
image

After:
image

Simplified UI + less XAML for diagnostics data:

Before:
image

After:
image

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@niels9001 niels9001 marked this pull request as draft June 26, 2025 12:27
@niels9001 niels9001 changed the title [Settings] String updates [Settings] String updates and minor UX tweaks Jun 26, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 26, 2025
View reviewed changes
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@niels9001 niels9001 marked this pull request as ready for review June 26, 2025 16:37
vanzue
vanzue approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@vanzue vanzue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change

@vanzue
Copy link
Contributor

vanzue commented Jun 27, 2025

image
We don't need it any more?

@niels9001
Copy link
Contributor Author

image We don't need it any more?

As far as I'm aware, this only opens the folder where the log files are stored. That has now turned into a Hyperlink so no features are lost :)

@niels9001
Copy link
Contributor Author

@vanzue I can't figure out why the CI is failing, would you mind taking a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanzue vanzue vanzue approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niels9001 @vanzue