Skip to content

Commit 73939ba

Browse files
author
Dale Myers
committed
Bump to 6.0.1
1 parent 6fcc0a6 commit 73939ba

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

asconnect/build_client.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -94,16 +94,16 @@ def get_build_from_identifier(self, identifier: str) -> Build | None:
9494

9595
return next_or_none(self.http_client.get(url=url, data_type=Build))
9696

97-
def get_from_build_number(self, bundle_id: str, build_number: str) -> Build | None:
97+
def get_from_build_number(self, app_id: str, build_number: str) -> Build | None:
9898
"""Get a build from its build number.
9999
100-
:param bundle_id: The bundle ID of the app
100+
:param app_id: The ID of the app
101101
:param build_number: The build number for the build to get
102102
103103
:returns: The build if found, None otherwise
104104
"""
105105

106-
self.log.info(f"Getting build from build number {build_number} for bundle {bundle_id}")
106+
self.log.info(f"Getting build from build number {build_number} for app {app_id}")
107107

108108
for build in self.get_builds(build_number=build_number):
109109
self.log.debug(f"Checking build {build}")
@@ -117,17 +117,17 @@ def get_from_build_number(self, bundle_id: str, build_number: str) -> Build | No
117117
if not app:
118118
break
119119

120-
if app.identifier == bundle_id:
120+
if app.identifier == app_id:
121121
return build
122122

123123
return None
124124

125125
def wait_for_build_to_process(
126-
self, bundle_id: str, build_number: str, wait_time: int = 30
126+
self, app_id: str, build_number: str, wait_time: int = 30
127127
) -> Build:
128128
"""Wait for a build to finish processing.
129129
130-
:param bundle_id: The ID of the app
130+
:param app_id: The ID of the app
131131
:param build_number: The build number for the build to wait for
132132
:param wait_time: The time to wait between checks for processing completion in seconds
133133
@@ -137,7 +137,7 @@ def wait_for_build_to_process(
137137

138138
while True:
139139
self.log.info("Waiting for build to appear...")
140-
build = self.get_from_build_number(bundle_id, build_number)
140+
build = self.get_from_build_number(app_id, build_number)
141141
if build is not None:
142142
break
143143
time.sleep(wait_time)

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "asconnect"
3-
version = "6.0.0"
3+
version = "6.0.1"
44
description = "A wrapper around the Apple App Store Connect APIs"
55

66
license = "MIT"

tests/test_asconnect.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ def test_get_build_localization_details() -> None:
249249
issuer_id=issuer_id,
250250
)
251251

252-
build = client.build.get_from_build_number(build_number="", bundle_id=APP_ID)
252+
build = client.build.get_from_build_number(build_number="", app_id=APP_ID)
253253

254254
assert build is not None
255255

@@ -266,7 +266,7 @@ def test_set_whats_new() -> None:
266266
issuer_id=issuer_id,
267267
)
268268

269-
build = client.build.get_from_build_number(build_number="", bundle_id=APP_ID)
269+
build = client.build.get_from_build_number(build_number="", app_id=APP_ID)
270270

271271
assert build is not None
272272

@@ -286,7 +286,7 @@ def test_get_build_beta_detail() -> None:
286286
issuer_id=issuer_id,
287287
)
288288

289-
build = client.build.get_from_build_number(build_number="", bundle_id=APP_ID)
289+
build = client.build.get_from_build_number(build_number="", app_id=APP_ID)
290290

291291
assert build is not None
292292

@@ -332,7 +332,7 @@ def test_set_beta_groups_detail() -> None:
332332

333333
assert app is not None
334334

335-
build = client.build.get_from_build_number(build_number="", bundle_id=APP_ID)
335+
build = client.build.get_from_build_number(build_number="", app_id=APP_ID)
336336

337337
assert build is not None
338338

@@ -355,7 +355,7 @@ def test_beta_review_submission() -> None:
355355
issuer_id=issuer_id,
356356
)
357357

358-
build = client.build.get_from_build_number(build_number="", bundle_id=APP_ID)
358+
build = client.build.get_from_build_number(build_number="", app_id=APP_ID)
359359

360360
assert build is not None
361361

0 commit comments

Comments
 (0)