Skip to content

Use new submit for review API #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Use new submit for review API #55

merged 1 commit into from
May 13, 2025

Conversation

dalemyers
Copy link
Collaborator

@dalemyers dalemyers commented Apr 23, 2025

The old version of this API has been deprecated and will no longer work from June 9th: https://developer.apple.com/documentation/appstoreconnectapi/post-v1-appstoreversionsubmissions

This moves to the new API.

Note: I haven't been able to test this yet. @JasperGuo / @Cokile if you have a test app you can test this with, it would be appreciated!

@dalemyers dalemyers requested review from Cokile and Copilot April 23, 2025 09:39
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the API submission method to use the new review endpoint, reflecting the deprecation of the old API.

  • Changed API endpoint from "appStoreVersionSubmissions" to "reviewSubmissions" and adjusted the related data structure
  • Added a new required parameter "platform" in the submit_for_review method and updated the corresponding README example

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
asconnect/version_client.py Updated API endpoint, payload structure, and method signature for new platform support
README.md Updated usage example to include the new platform parameter
Comments suppressed due to low confidence (2)

asconnect/version_client.py:443

  • The new 'platform' parameter is introduced without corresponding tests. Please add tests to verify its behavior, including handling of valid platform values and error scenarios.
+        platform: Platform,

README.md:69

  • The usage example assumes access to the Platform enum. Please ensure that the example includes an import statement or clear instructions on how to reference the Platform enum.
client.version.submit_for_review(version_id=version.identifier, platform=Platform.IOS)

@dalemyers dalemyers requested a review from JasperGuo April 23, 2025 09:40
@Cokile
Copy link
Collaborator

Cokile commented Apr 24, 2025

FYI: we tried to migrate to use the new API before, and fixed some bugs: #46, #47, but the API seems not work as expected, so we reverted it back: #50

@dalemyers dalemyers force-pushed the dalemyers/submit_for_review branch from c96d91c to dea9871 Compare April 28, 2025 11:31
@dalemyers dalemyers force-pushed the dalemyers/submit_for_review branch from dea9871 to 873f488 Compare April 28, 2025 11:32
@dalemyers
Copy link
Collaborator Author

FYI: we tried to migrate to use the new API before, and fixed some bugs: #46, #47, but the API seems not work as expected, so we reverted it back: #50

That's somewhat annoying. It's been a year though, so maybe things have improved? The API we were using is going away, so I don't think we have much choice but to go with this approach and try and deal with issues if/when they come up?

@Cokile Cokile merged commit f2d1fdd into main May 13, 2025
4 checks passed
@Cokile Cokile deleted the dalemyers/submit_for_review branch May 13, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants