PSv5 backward compatibility for Invoke-WebRequest

Author: TinaMor

Tests/CommonToolUtilities.Tests.ps1

@@ -253,9 +253,11 @@ Describe "CommonToolUtilities.psm1" {
         It "Should throw an error if download fails" {
             $errorMessage = "Response status code does not indicate success: 404 (Not Found)."
             Mock Invoke-WebRequest { Throw $errorMessage } -ModuleName "CommonToolUtilities"
+            Mock Start-Sleep -ModuleName "CommonToolUtilities"
 
             { Get-InstallationFile -FileParameters $Script:MockFiles } | Should -Throw "Failed to download asset*"
-            $Error[1].Exception.Message | Should -BeLike "Failed to download assets for `"v2.0.0-rc.1`". Couldn`'t download `"v2.0.0-rc.1`" release assets.*"
+            Should -Invoke Invoke-WebRequest -Times 3 -Scope It -ModuleName "CommonToolUtilities"
+            $Error[1].Exception.Message | Should -BeLike "Failed to download assets for `"v2.0.0-rc.1`". Couldn`'t download `"v2.0.0-rc.1`" release assets*"
         }
     }
 

containers-toolkit/Private/CommonToolUtilities.psm1

@@ -205,12 +205,26 @@ function Get-InstallationFile {
     begin {
         function Receive-File {
             param($params)
-            try {
-                Invoke-WebRequest -Uri $params.Uri -OutFile $params.DownloadPath -UseBasicParsing -MaximumRetryCount 3 -RetryIntervalSec 60
-            }
-            catch {
-                Throw "Couldn't download `"$($params.Feature)`" release assets. `"$($params.Uri)`".`n$($_.Exception.Message)"
-            }
+
+            $MaximumRetryCount = 3
+            $RetryIntervalSec = 60
+            $lastError = $null  # Store the last exception
+
+            do {
+                try {
+                    Invoke-WebRequest -Uri $params.Uri -OutFile $params.DownloadPath -UseBasicParsing
+                    return
+                }
+                catch {
+                    $lastError = $_  # Store the last error for proper exception handling
+                    Write-Warning "Failed to download `"$($params.Feature)`" release assets. Retrying... ($MaximumRetryCount retries left)"
+                    Start-Sleep -Seconds $RetryIntervalSec
+                    $MaximumRetryCount -= 1
+                }
+            } while ($MaximumRetryCount -gt 0)
+
+            # Throw the last encountered error after all retries fail
+            Throw "Couldn't download `"$($params.Feature)`" release assets from `"$($params.Uri)`".`n$($lastError.Exception.Message)"
         }
 
         function DownloadAssets {