Skip to content

Refactor 'Install-WinCNIPlugin' to use 'Install-RequiredFeature' #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

TinaMor
Copy link
Contributor

@TinaMor TinaMor commented Jan 29, 2025

PR description

Refactor 'Install-WinCNIPlugin' to use 'Install-RequiredFeature to make it easier to maintain.

Checklist

As part of our commitment to engineering excellence, before submitting this PR, please make sure:

  • You've tested this code in both Desktop & Server environments and AMD & ARM64 enviroments (functional testing).
  • You've reviewed the PR/code best practices defined in the CONTRIBUTING.md.
  • You've added unit tests for new code.
  • You've added/updated documentation in the cmdlet docs, command-reference.md and the modules help files.

In addition, after this PR has been reviewed, please agree to:

  • Validate your changes have not introduced any regressions.
  • If changes have been made to your PR in the process of addressing comments, please make sure to test again the final version in both AMD and ARM64 environments.

@TinaMor TinaMor marked this pull request as ready for review February 3, 2025 17:58
@TinaMor TinaMor requested a review from iankingori as a code owner February 3, 2025 17:58
@TinaMor TinaMor marked this pull request as draft February 3, 2025 18:07
billywr
billywr previously approved these changes Feb 3, 2025
@TinaMor TinaMor marked this pull request as ready for review February 4, 2025 10:47
@TinaMor TinaMor merged commit 7cb550b into microsoft:main Feb 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants