Skip to content

[torchlib] Make index_put dynamic #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

justinchuby
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented May 1, 2025

❌ 7 Tests Failed:

Tests completed Failed Passed Skipped
5782 7 5775 3226
View the top 3 failed test(s) by shortest run time
::onnxscript.function_libs.tools.torch_lib.deduce_type_constraints_test
Stack Traces | 0s run time
..../test_torch_nightly/lib/python3.11.../site-packages/_pytest/python.py:493: in importtestmodule
    mod = import_path(
..../test_torch_nightly/lib/python3.11.../site-packages/_pytest/pathlib.py:587: in import_path
    importlib.import_module(module_name)
.../Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1204: in _gcd_import
    ???
<frozen importlib._bootstrap>:1176: in _find_and_load
    ???
<frozen importlib._bootstrap>:1147: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:690: in _load_unlocked
    ???
..../test_torch_nightly/lib/python3.11.../_pytest/assertion/rewrite.py:185: in exec_module
    exec(co, module.__dict__)
.../tools/torch_lib/deduce_type_constraints_test.py:15: in <module>
    import onnxscript.function_libs.torch_lib.ops  # Import to populate registry
.../torch_lib/ops/__init__.py:16: in <module>
    from . import (
E     File ".../torch_lib/ops/core.py", line 4331
E       TODO(justinchuby): Here
E       ^^^^^^^^^^^^^^^^^
E   SyntaxError: illegal target for annotation
::onnxscript.function_libs.torch_lib.graph_building.__init__
Stack Traces | 0s run time
..../test_torch_nightly/lib/python3.11.../site-packages/_pytest/python.py:493: in importtestmodule
    mod = import_path(
..../test_torch_nightly/lib/python3.11.../site-packages/_pytest/pathlib.py:587: in import_path
    importlib.import_module(module_name)
.../Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1204: in _gcd_import
    ???
<frozen importlib._bootstrap>:1176: in _find_and_load
    ???
<frozen importlib._bootstrap>:1147: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:690: in _load_unlocked
    ???
<frozen importlib._bootstrap_external>:940: in exec_module
    ???
<frozen importlib._bootstrap>:241: in _call_with_frames_removed
    ???
.../torch_lib/graph_building/__init__.py:44: in <module>
    from ._graph_building_torch import (
.../torch_lib/graph_building/_graph_building_torch.py:27: in <module>
    from onnxscript.function_libs.torch_lib.ops import common as common_ops
.../torch_lib/ops/__init__.py:16: in <module>
    from . import (
E     File ".../torch_lib/ops/core.py", line 4331
E       TODO(justinchuby): Here
E       ^^^^^^^^^^^^^^^^^
E   SyntaxError: illegal target for annotation
::onnxscript.function_libs.torch_lib.ops.__init__
Stack Traces | 0s run time
..../test_torch_nightly/lib/python3.11.../site-packages/_pytest/python.py:493: in importtestmodule
    mod = import_path(
..../test_torch_nightly/lib/python3.11.../site-packages/_pytest/pathlib.py:587: in import_path
    importlib.import_module(module_name)
.../Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1204: in _gcd_import
    ???
<frozen importlib._bootstrap>:1176: in _find_and_load
    ???
<frozen importlib._bootstrap>:1147: in _find_and_load_unlocked
    ???
<frozen importlib._bootstrap>:690: in _load_unlocked
    ???
<frozen importlib._bootstrap_external>:940: in exec_module
    ???
<frozen importlib._bootstrap>:241: in _call_with_frames_removed
    ???
.../torch_lib/ops/__init__.py:16: in <module>
    from . import (
E     File ".../torch_lib/ops/core.py", line 4331
E       TODO(justinchuby): Here
E       ^^^^^^^^^^^^^^^^^
E   SyntaxError: illegal target for annotation

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@justinchuby
Copy link
Collaborator Author

Todo: look at aten_index()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant