[RFC] openhcl_boot: persist memory topology when servicing #1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
save 2 impl allocs more impl alloc range should have persisted region builds now, but faults when reading persisted region works uses local map but needs cleanup skeleton but allocation fails fix allocator bug start unwinding hacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still some TODO comments to clean up but opening early to get some comments/help decide if we should do some refactoring first before merging this. This PR is also dependent on this PR or an equivalent solution.
The current implementation puts a persisted state header at the start of VTL2 memory that points to the first of potentially many persisted state blobs present in memory across servicing (implementing link to another block is still TODO). If no persisted state header is found, this implementation carves out 512 pages from the end of VTL2 memory for persistence.