simplify process code #5171
Open
simplify process code #5171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
May 30, 2025
| @@ -5,9 +5,13 @@ namespace Microsoft.Testing.Platform.Helpers; | |||
|
|
|||
| internal interface IProcessHandler | |||
| { | |||
| IProcess GetProcessById(int pid); | |||
There was a problem hiding this comment.
Let's add the new needed APIs without removing the existing ones.
While it's internal, it's used by HangDump via IVT.
This means, if user updates core MTP but didn't update HangDump, it will fail with MissingMethodException. While this has happened multiple times in the past already, let's be careful to avoid it whenever possible.
There was a problem hiding this comment.
Also hard Deprecate that old api? It should not fail on runtime, but should not build for new code.
Youssef1313
reviewed
Jun 10, 2025
| public async Task KillAsync(int id) | ||
| { | ||
| using var process = Process.GetProcessById(id); | ||
| process.Kill(); |
There was a problem hiding this comment.
Kill(true) on .NET Core to kill child processes as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
less code and fixes some missing usings