Ensure MSTest.GlobalConfigsGenerator is built before MSTest.Analyzers.Package #5807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Jun 18, 2025
Comment on lines
+166
to
+168
| ProjectSection(ProjectDependencies) = postProject | ||
| {A85AA656-6DB6-4A0B-AA80-CBB4058B3DDB} = {A85AA656-6DB6-4A0B-AA80-CBB4058B3DDB} | ||
| EndProjectSection |
There was a problem hiding this comment.
We only use .sln on Windows currently. So this won't work for Linux/macOS.
Lines 8 to 10 in 7bf53d1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5807 +/- ##
==========================================
- Coverage 73.41% 73.34% -0.07%
==========================================
Files 605 605
Lines 37921 37921
==========================================
- Hits 27839 27814 -25
- Misses 10082 10107 +25
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
dotnet runcould be invoking a build which is racing with the main build of GlobalConfigsGenerator. Adding aProjectReferenceto force GlobalConfigsGenerator to be built before MSTest.Analyzers.Package. Then invokingdotnet runwith--no-build.