Include full diagnostic chains in LSP diagnostics #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahejlsberg
requested review from
Copilot,
jakebailey and
andrewbranch
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR enhances LSP diagnostics by including full diagnostic message chains rather than only the primary message.
- Switches
MessageintoLSPDiagnosticto use a newmessageChainToStringhelper. - Adds
messageChainToStringto flatten multi-part diagnostic messages. - Imports
stringsand thediagnosticwriterpackage to support the new helper.
Comments suppressed due to low confidence (1)
internal/ls/diagnostics.go:100
- Add unit tests covering the new
messageChainToStringlogic to ensure diagnostic chains are flattened correctly in LSP output.
func messageChainToString(diagnostic *ast.Diagnostic) string {
jakebailey
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.