Skip to content

[WIP] Port TypeScript PR #60195: Assume that type node annotations resolving to error types can be reused #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[WIP] Port TypeScript PR #60195: Assume that type node annotations resolving to error types can be reused #1137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84de4c9
Initial plan for issue
Copilot Jun 10, 2025
fba53fe
Changes before error encountered
Copilot Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/checker/nodebuilderimpl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,12 @@ func (b *nodeBuilderImpl) tryReuseExistingNonParameterTypeNode(existing *ast.Typ
if annotationType == nil {
annotationType = b.getTypeFromTypeNode(existing, true)
}
if b.ch.isErrorType(annotationType) {
// allow "reusing" type nodes that resolve to error types
// those can't truly be reused but it prevents cascading errors in isolatedDeclarations
// for source with errors there is no guarantee to emit correct code anyway
return existing
}
if annotationType != nil && b.typeNodeIsEquivalentToType(host, t, annotationType) && b.existingTypeNodeIsNotReferenceOrIsReferenceWithCompatibleTypeArgumentCount(existing, t) {
result := b.tryReuseExistingTypeNodeHelper(existing)
if result != nil {
Expand Down