Simplify parser options passing, share ASTs even more #1158
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,137 @@ | ||
| package ast | ||
|
|
||
| import ( | ||
| "github.com/microsoft/typescript-go/internal/core" | ||
| "github.com/microsoft/typescript-go/internal/tspath" | ||
| ) | ||
|
|
||
| type ExternalModuleIndicatorOptions struct { | ||
| jsx bool | ||
| force bool | ||
| } | ||
|
There was a problem hiding this comment. Shifting this code around now means that the entire cache key for the external module indicator is just these two booleans! So much more reuse. |
||
|
|
||
| func GetExternalModuleIndicatorOptions(fileName string, options *core.CompilerOptions, metadata SourceFileMetaData) ExternalModuleIndicatorOptions { | ||
| if tspath.IsDeclarationFileName(fileName) { | ||
| return ExternalModuleIndicatorOptions{} | ||
| } | ||
|
|
||
| switch options.GetEmitModuleDetectionKind() { | ||
| case core.ModuleDetectionKindForce: | ||
| // All non-declaration files are modules, declaration files still do the usual isFileProbablyExternalModule | ||
| return ExternalModuleIndicatorOptions{force: true} | ||
| case core.ModuleDetectionKindLegacy: | ||
| // Files are modules if they have imports, exports, or import.meta | ||
| return ExternalModuleIndicatorOptions{} | ||
| case core.ModuleDetectionKindAuto: | ||
| // If module is nodenext or node16, all esm format files are modules | ||
| // If jsx is react-jsx or react-jsxdev then jsx tags force module-ness | ||
| // otherwise, the presence of import or export statments (or import.meta) implies module-ness | ||
| return ExternalModuleIndicatorOptions{ | ||
| jsx: options.Jsx == core.JsxEmitReactJSX || options.Jsx == core.JsxEmitReactJSXDev, | ||
| force: isFileForcedToBeModuleByFormat(fileName, options, metadata), | ||
| } | ||
| default: | ||
| return ExternalModuleIndicatorOptions{} | ||
| } | ||
| } | ||
|
|
||
| var isFileForcedToBeModuleByFormatExtensions = []string{tspath.ExtensionCjs, tspath.ExtensionCts, tspath.ExtensionMjs, tspath.ExtensionMts} | ||
|
|
||
| func isFileForcedToBeModuleByFormat(fileName string, options *core.CompilerOptions, metadata SourceFileMetaData) bool { | ||
| // Excludes declaration files - they still require an explicit `export {}` or the like | ||
| // for back compat purposes. The only non-declaration files _not_ forced to be a module are `.js` files | ||
| // that aren't esm-mode (meaning not in a `type: module` scope). | ||
| if GetImpliedNodeFormatForEmitWorker(fileName, options.GetEmitModuleKind(), metadata) == core.ModuleKindESNext || tspath.FileExtensionIsOneOf(fileName, isFileForcedToBeModuleByFormatExtensions) { | ||
| return true | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| func SetExternalModuleIndicator(file *SourceFile, opts ExternalModuleIndicatorOptions) { | ||
| file.ExternalModuleIndicator = getExternalModuleIndicator(file, opts) | ||
| } | ||
|
|
||
| func getExternalModuleIndicator(file *SourceFile, opts ExternalModuleIndicatorOptions) *Node { | ||
| if file.ScriptKind == core.ScriptKindJSON { | ||
| return nil | ||
| } | ||
|
|
||
| if node := isFileProbablyExternalModule(file); node != nil { | ||
| return node | ||
| } | ||
|
|
||
| if file.IsDeclarationFile { | ||
| return nil | ||
| } | ||
|
|
||
| if opts.jsx { | ||
| if node := isFileModuleFromUsingJSXTag(file); node != nil { | ||
| return node | ||
| } | ||
| } | ||
|
|
||
| if opts.force { | ||
| return file.AsNode() | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func isFileProbablyExternalModule(sourceFile *SourceFile) *Node { | ||
| for _, statement := range sourceFile.Statements.Nodes { | ||
| if IsExternalModuleIndicator(statement) { | ||
| return statement | ||
| } | ||
| } | ||
| return getImportMetaIfNecessary(sourceFile) | ||
| } | ||
|
|
||
| func getImportMetaIfNecessary(sourceFile *SourceFile) *Node { | ||
| if sourceFile.AsNode().Flags&NodeFlagsPossiblyContainsImportMeta != 0 { | ||
| return findChildNode(sourceFile.AsNode(), IsImportMeta) | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func findChildNode(root *Node, check func(*Node) bool) *Node { | ||
| var result *Node | ||
| var visit func(*Node) bool | ||
| visit = func(node *Node) bool { | ||
| if check(node) { | ||
| result = node | ||
| return true | ||
| } | ||
| return node.ForEachChild(visit) | ||
| } | ||
| visit(root) | ||
| return result | ||
| } | ||
|
|
||
| func isFileModuleFromUsingJSXTag(file *SourceFile) *Node { | ||
| return walkTreeForJSXTags(file.AsNode()) | ||
| } | ||
|
|
||
| // This is a somewhat unavoidable full tree walk to locate a JSX tag - `import.meta` requires the same, | ||
| // but we avoid that walk (or parts of it) if at all possible using the `PossiblyContainsImportMeta` node flag. | ||
| // Unfortunately, there's no `NodeFlag` space to do the same for JSX. | ||
| func walkTreeForJSXTags(node *Node) *Node { | ||
| var found *Node | ||
|
|
||
| var visitor func(node *Node) bool | ||
| visitor = func(node *Node) bool { | ||
| if found != nil { | ||
| return true | ||
| } | ||
| if node.SubtreeFacts()&SubtreeContainsJsx == 0 { | ||
| return false | ||
| } | ||
| if IsJsxOpeningElement(node) || IsJsxFragment(node) { | ||
| found = node | ||
| return true | ||
| } | ||
| return node.ForEachChild(visitor) | ||
| } | ||
| visitor(node) | ||
|
|
||
| return found | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.