JSX completions #863
Merged
JSX completions #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabritto
force-pushed
the
gabritto/jsxcompletion
branch
from
996cc6d to
d37a694
Compare
gabritto
commented
May 15, 2025
| @@ -1907,128 +1920,29 @@ func (l *LanguageService) createCompletionItem( | |||
| // Otherwise use the completion list default. | |||
| } | |||
|
|
|||
| // Text edit | |||
There was a problem hiding this comment.
This all got moved to createLSPCompletionItem so it can be reused in other places that also created completion entries and now need to create an LSP completion item.
jakebailey
reviewed
May 15, 2025
jakebailey
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fill in the JSX-related places in completions.
Follow-up of #858.