Skip to content

Commit 3efab86

Browse files
committed
Fix terminal icon picker issues
Fixes #251428
1 parent 5c8496a commit 3efab86

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/vs/workbench/contrib/terminal/browser/terminalIconPicker.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,7 @@ export class TerminalIconPicker extends Disposable {
4545

4646
this._iconSelectBox = instantiationService.createInstance(WorkbenchIconSelectBox, {
4747
icons: icons.value,
48-
inputBoxStyles: defaultInputBoxStyles,
49-
showIconInfo: true
48+
inputBoxStyles: defaultInputBoxStyles
5049
});
5150
}
5251

@@ -58,18 +57,21 @@ export class TerminalIconPicker extends Disposable {
5857
this._iconSelectBox.dispose();
5958
}));
6059
this._iconSelectBox.clearInput();
60+
const body = getActiveDocument().body;
61+
const bodyRect = body.getBoundingClientRect();
6162
const hoverWidget = this._hoverService.showInstantHover({
6263
content: this._iconSelectBox.domNode,
63-
target: getActiveDocument().body,
64+
target: {
65+
targetElements: [body],
66+
x: bodyRect.left + (bodyRect.width - dimension.width) / 2,
67+
y: bodyRect.top
68+
},
6469
position: {
6570
hoverPosition: HoverPosition.BELOW,
6671
},
6772
persistence: {
6873
sticky: true,
6974
},
70-
appearance: {
71-
showPointer: true
72-
}
7375
}, true);
7476
if (hoverWidget) {
7577
this._register(hoverWidget);

0 commit comments

Comments
 (0)