Skip to content

Commit 9a0a54c

Browse files
authored
Fix "tool undefined completed" accessibility announcement in chat (#251442)
1 parent 20b6940 commit 9a0a54c

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

src/vs/workbench/contrib/chat/browser/chatAccessibilityProvider.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,17 @@ export class ChatAccessibilityProvider implements IListAccessibilityProvider<Cha
8888
toolInvocationHint = this._instantiationService.invokeFunction(getToolConfirmationAlert, toolInvocation);
8989
} else { // all completed
9090
for (const invocation of toolInvocation) {
91-
toolInvocationHint += localize('toolCompletedHint', "Tool {0} completed.", typeof invocation.confirmationMessages?.title === 'string' ? invocation.confirmationMessages?.title : invocation.confirmationMessages?.title.value);
91+
const titleObj = invocation.confirmationMessages?.title;
92+
let title = '';
93+
if (typeof titleObj === 'string' && titleObj.trim()) {
94+
title = titleObj;
95+
} else if (titleObj && typeof titleObj === 'object' && 'value' in titleObj && titleObj.value && titleObj.value.trim()) {
96+
title = titleObj.value;
97+
} else {
98+
// Fallback to toolId if no valid title
99+
title = invocation.toolId;
100+
}
101+
toolInvocationHint += localize('toolCompletedHint', "Tool {0} completed.", title);
92102
}
93103
}
94104
}

0 commit comments

Comments
 (0)